sijie commented on a change in pull request #888: Rework of binary distribution licenses URL: https://github.com/apache/bookkeeper/pull/888#discussion_r161181238
########## File path: bookkeeper-dist/src/main/resources/NOTICE-all.bin.txt ########## @@ -1,55 +1,136 @@ Apache BookKeeper -Copyright 2011-2017 The Apache Software Foundation +Copyright 2011-2018 The Apache Software Foundation -Licensed under the Apache License, Version 2.0 (the -"License"); you may not use this file except in compliance +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). + +------------------------------------------------------------------------------------ +- lib/io.dropwizard.metrics-metrics-core-3.1.0.jar Review comment: It is okay and enough to keep versioning in LICENSE. However I would suggest removing versioning from NOTICE file: 1) versioning is not legally required in NOTICE. 2) NOTICE as short as possible as it will affect downstream projects. this is going to cause NOTICE updates everytime we bumped version. http://www.apache.org/dev/licensing-howto.html#mod-notice ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
