sijie commented on a change in pull request #888: Rework of binary distribution licenses URL: https://github.com/apache/bookkeeper/pull/888#discussion_r161277183
########## File path: bookkeeper-dist/src/main/resources/NOTICE-all.bin.txt ########## @@ -1,55 +1,136 @@ Apache BookKeeper -Copyright 2011-2017 The Apache Software Foundation +Copyright 2011-2018 The Apache Software Foundation -Licensed under the Apache License, Version 2.0 (the -"License"); you may not use this file except in compliance +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). + +------------------------------------------------------------------------------------ +- lib/io.dropwizard.metrics-metrics-core-3.1.0.jar Review comment: I know notices can change between version. my point is most of the dependencies are having versioning references in LICENSE, which automated checking will fail the a dependency change if the versioning is not updated. automated checking does its job on license/versioning and the contributors/reviewers should check both license/notice on reviewing it. automated checking on LICENSE is enough for capturing this. The reason I would suggest removing versions from NOTICE, as the ASF polices suggest and the practices that people have, is to avoid unnecessary changes to NOTICE as possible, keep it as brief as possible, and avoid impacting downstream projects as little as possible. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
