eolivelli commented on a change in pull request #1018: Issue1007: move checksum 
to proto
URL: https://github.com/apache/bookkeeper/pull/1018#discussion_r162746420
 
 

 ##########
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java
 ##########
 @@ -653,7 +653,9 @@ public RegistrationClient getRegClient() {
      * cheap to compute but does not protect against byzantine bookies (i.e., a
      * bookie might report fake bytes and a matching CRC32). The MAC code is 
more
      * expensive to compute, but is protected by a password, i.e., a bookie 
can't
-     * report fake bytes with a mathching MAC unless it knows the password
+     * report fake bytes with a mathching MAC unless it knows the password.
+     * legacy DigestType for back compatible,
 
 Review comment:
   Typo: back compatible -> backward compatibility

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to