eolivelli commented on a change in pull request #1018: Issue1007: move checksum
to proto
URL: https://github.com/apache/bookkeeper/pull/1018#discussion_r162746804
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/checksum/DigestManager.java
##########
@@ -210,14 +210,17 @@ long verifyDigestAndReturnLac(ByteBuf dataReceived)
throws BKDigestMatchExceptio
* @return
* @throws BKDigestMatchException
*/
- ByteBuf verifyDigestAndReturnData(long entryId, ByteBuf dataReceived)
+ public ByteBuf verifyDigestAndReturnData(long entryId, ByteBuf
dataReceived)
throws BKDigestMatchException {
verifyDigest(entryId, dataReceived);
dataReceived.readerIndex(METADATA_LENGTH + macCodeLength);
return dataReceived;
}
- static class RecoveryData {
+ /**
+ * A representation of RecoveryData.
+ */
+ public static class RecoveryData {
Review comment:
Maybe we can add 'final' here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
