eolivelli commented on a change in pull request #1018: Issue1007: move checksum 
to proto
URL: https://github.com/apache/bookkeeper/pull/1018#discussion_r162747436
 
 

 ##########
 File path: 
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/MockBookKeeperTestCase.java
 ##########
 @@ -363,7 +370,11 @@ protected void setupBookieClientReadEntry() {
                 (BookkeeperInternalCallbacks.ReadEntryCallback) args[3];
 
             executor.submitOrdered(ledgerId, () -> {
-                DigestManager macManager = new CRC32DigestManager(ledgerId);
+                DigestManager macManager = null;
+                try {
+                    macManager = DigestManager.instantiate(ledgerId, new 
byte[2], DigestType.CRC32);
+                } catch (GeneralSecurityException gse){
 
 Review comment:
   Same add above

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to