eolivelli commented on a change in pull request #1018: Issue1007: move checksum
to proto
URL: https://github.com/apache/bookkeeper/pull/1018#discussion_r162747872
##########
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/ClientUtil.java
##########
@@ -31,7 +34,13 @@ public static ByteBuf generatePacket(long ledgerId, long
entryId, long lastAddCo
public static ByteBuf generatePacket(long ledgerId, long entryId, long
lastAddConfirmed,
long length, byte[] data, int
offset, int len) {
- CRC32DigestManager dm = new CRC32DigestManager(ledgerId);
+ DigestManager dm = null;
+ try {
+ // CRC32 need not password, and is support definitely currently.
+ dm = DigestManager.instantiate(ledgerId, new byte[2], CRC32);
+ } catch (GeneralSecurityException gse) {
+
Review comment:
Rethrow or at least log
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
