ivankelly commented on a change in pull request #970: ISSUE #966: Expose quorum
write complete latency to the client
URL: https://github.com/apache/bookkeeper/pull/970#discussion_r164164388
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingAddOp.java
##########
@@ -344,7 +347,11 @@ void submitCallback(final int rc) {
} else {
addOpLogger.registerSuccessfulEvent(latencyNanos,
TimeUnit.NANOSECONDS);
}
- cb.addComplete(rc, lh, entryId, ctx);
+ if (lh instanceof LedgerHandleAdv) {
Review comment:
This instanceof is unnecessary. addCompleteAdv calls addComplete by default
anyhow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
