ivankelly commented on a change in pull request #970: ISSUE #966: Expose quorum
write complete latency to the client
URL: https://github.com/apache/bookkeeper/pull/970#discussion_r163205587
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandleAdv.java
##########
@@ -152,8 +153,33 @@ public void asyncAddEntry(final long entryId, final
byte[] data, final int offse
asyncAddEntry(entryId, Unpooled.wrappedBuffer(data, offset, length),
cb, ctx);
}
+ /**
+ * Add entry asynchronously to an open ledger, using an offset and range.
+ *
+ * @param entryId
+ * entryId of the entry to add
+ * @param data
+ * array of bytes to be written
+ * @param offset
+ * offset from which to take bytes from data
+ * @param length
+ * number of bytes to take from data
+ * @param cb
+ * object implementing callbackinterface
+ * @param ctx
+ * some control object
+ * @throws ArrayIndexOutOfBoundsException
+ * if offset or length is negative or offset and length sum to
a
+ * value higher than the length of data.
+ */
+ @Override
+ public void asyncAddEntry(final long entryId, final byte[] data, final int
offset, final int length,
Review comment:
> 2) they are going to be deprecated in next release after the yahoo and
sales force merge.
Why even add a new interface now, if the plan is to deprecate so soon?
I don't see the new api moving to stable that quick.
- All our tests should be moved to new api before that.
- We need BC tests on the new api so we don't actually break it once we move
to stable
- There is still inconsistency in the api which needs to be addressed.
> I don?t think it is worth changing that and blocking this change at this
moment.
You can merge this if you want. I don't consider this blocking.
Looking at this change again, I don't see why we need these extra calls on
LedgerHandle at all though. We could just add a default on addComplete() and
then the user could implement which callback they want to implement (and these
would have their stability labelled correctly).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
