ivankelly commented on a change in pull request #970: ISSUE #966: Expose quorum 
write complete latency to the client
URL: https://github.com/apache/bookkeeper/pull/970#discussion_r164684702
 
 

 ##########
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/AsyncCallback.java
 ##########
 @@ -48,6 +48,24 @@
          *          context object
          */
         void addComplete(int rc, LedgerHandle lh, long entryId, Object ctx);
 
 Review comment:
   Oops, meant to reply yesterday. Yes, since it would break the functional 
stuff, we have to add a new interface. In that case, I'd keep both callbacks 
completely separate, so that both can be functional.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to