ivankelly commented on a change in pull request #970: ISSUE #966: Expose quorum
write complete latency to the client
URL: https://github.com/apache/bookkeeper/pull/970#discussion_r164165981
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/AsyncCallback.java
##########
@@ -48,6 +48,24 @@
* context object
*/
void addComplete(int rc, LedgerHandle lh, long entryId, Object ctx);
Review comment:
What was saying in the meeting,but wasn't very clear, is that if you add a
default to addComplete, then all users of asyncAddEntry can take advantage of
this latency reporting (not just the LedgerHandleAdv users).
As it is now, a user would have to override addComplete and addCompleteAdv
to use the a latency stuff. If addComplete has a default, then existing code
will continue to work, but a user who wants latency information can override
only addCompleteAdv, ignoring addComplete.
The addComplete default can be empty, as the bookkeeper code only calls
addCompleteAdv. addComplete is _only_ ever called by addCompleteAdv, in the
case that addCompleteAdv isn't implemented.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
