reddycharan commented on a change in pull request #1100: Improve decomission
test
URL: https://github.com/apache/bookkeeper/pull/1100#discussion_r165725190
##########
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieDecommissionTest.java
##########
@@ -44,14 +46,17 @@
public BookieDecommissionTest() {
super(NUM_OF_BOOKIES, 480);
- baseConf.setOpenLedgerRereplicationGracePeriod(String.valueOf(30000));
- setAutoRecoveryEnabled(true);
+ baseConf.setOpenLedgerRereplicationGracePeriod(100);
+ setAutoRecoveryEnabled(false);
Review comment:
I'm not sure how can this be ok? you disabled AutoRecoveryService for all
the bookies by setting this to false, but in each testcase you are starting
AutoRecoveryMain (which starts daemon for Auditor and ReplicationWorker) just
for one bookie. How come having just one bookie ReplicationWorker would be
sufficient for these testcases where we are killing bookie/s?
My concern here is if the bookie which is having AutoRecoveryMain is already
having copy of fragments of that ledger, then it would ignore replicating that
under replicated ledger to that Bookie, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
