reddycharan commented on a change in pull request #1100: Improve decomission 
test
URL: https://github.com/apache/bookkeeper/pull/1100#discussion_r165754551
 
 

 ##########
 File path: 
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieDecommissionTest.java
 ##########
 @@ -86,7 +91,18 @@ public void testDecommissionBookie() throws Exception {
          * this decommisionBookie should make sure that there are no
          * underreplicated ledgers because of this bookie
          */
-        bkAdmin.decommissionBookie(Bookie.getBookieAddress(killedBookieConf));
+        bkAdmin.decommissionBookie(
+            Bookie.getBookieAddress(killedBookieConf),
+            () -> {
+                Auditor auditor = recoveryProcess.getAuditor();
+                if (null != auditor) {
 
 Review comment:
   hmm..in hypothetical scenario if it is null, then aren't we just ignoring 
it? is that ok to just ignore the fact that auditor is null and proceed with 
the test logic without waiting for auditor to do its auditing bookies task? 
   
   Anyhow, I'm still not convinced how can we be ok with Auditor to be null? If 
there is no Auditor, then there is no replication process, right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to