reddycharan commented on a change in pull request #1100: Improve decomission 
test
URL: https://github.com/apache/bookkeeper/pull/1100#discussion_r165758468
 
 

 ##########
 File path: 
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieDecommissionTest.java
 ##########
 @@ -44,14 +46,17 @@
 
     public BookieDecommissionTest() {
         super(NUM_OF_BOOKIES, 480);
-        baseConf.setOpenLedgerRereplicationGracePeriod(String.valueOf(30000));
-        setAutoRecoveryEnabled(true);
+        baseConf.setOpenLedgerRereplicationGracePeriod(100);
 
 Review comment:
   ok..i forgot that in this test 
testDecommissionForLedgersWithMultipleSegmentsAndNotWriteClosed, there are not 
writeclosed ledgers and they will remain underreplicated for 
openLedgerRereplicationGracePeriod. 
   
   Anyhow isn't 100 millsec too less? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to