reddycharan commented on a change in pull request #1100: Improve decomission 
test
URL: https://github.com/apache/bookkeeper/pull/1100#discussion_r165756792
 
 

 ##########
 File path: 
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieDecommissionTest.java
 ##########
 @@ -44,14 +46,17 @@
 
     public BookieDecommissionTest() {
         super(NUM_OF_BOOKIES, 480);
-        baseConf.setOpenLedgerRereplicationGracePeriod(String.valueOf(30000));
-        setAutoRecoveryEnabled(true);
+        baseConf.setOpenLedgerRereplicationGracePeriod(100);
+        setAutoRecoveryEnabled(false);
 
 Review comment:
   I dont get your point  - "we don't need to start autorecovery on every 
bookie"
   
   lets say there are 6 Bookies - BK0, BK1, BK2,..BK5 and Ledger with quorum 
3,3 is created.
   you started AutoRecovery process for only one Bookie - BK0. So for BK0 
Auditor and ReplicationWorker daemons are running.
   
   LID-P (ledger) : BK0, BK1, BK2 (ensemble)
   
   Now if BK1 is killed, so LID-P will be underreplicated. My question is 
though AutoRecovery (Auditor, ReplicationWorker) are running for BK0, LID-P 
will remain under-replicated, right? Since, BK0 is already part of ensemble of 
LID-P, ReplicationWorker running with BK0 wouldn't be able to do anything.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to