dlg99 commented on a change in pull request #1088: ISSUE #1086 (@bug
W-4146427@) Client-side backpressure in netty (Fixes:
io.netty.util.internal.OutOfDirectMemoryError under continuous heavy load)
URL: https://github.com/apache/bookkeeper/pull/1088#discussion_r168646267
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
##########
@@ -148,6 +157,7 @@
this.enableParallelRecoveryRead =
bk.getConf().getEnableParallelRecoveryRead();
this.recoveryReadBatchSize = bk.getConf().getRecoveryReadBatchSize();
this.writeFlags = writeFlags;
+ this.waitForWriteSetMs =
bk.getConf().getWaitTimeoutOnBackpressureMillis();
Review comment:
I don't think reads vs writes matter in this case.
Writes wait for full WQ (i.e. if when any 1 out of 3 not writable), reads
wait one (i.e. when 3 out of 3 not writable) so they should not be affected by
wait that much. Writes have a chance to recover with ensemble change but we
don't want frequent ensemble changes; reads will simply fail.
Combined with netty's L/H water mark configs this really should happen in
extreme cases only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
