dlg99 commented on a change in pull request #1088: ISSUE #1086 (@bug
W-4146427@) Client-side backpressure in netty (Fixes:
io.netty.util.internal.OutOfDirectMemoryError under continuous heavy load)
URL: https://github.com/apache/bookkeeper/pull/1088#discussion_r173325181
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperClientStats.java
##########
@@ -67,6 +67,7 @@
String CHANNEL_START_TLS_OP = "START_TLS";
String CHANNEL_TIMEOUT_START_TLS_OP = "TIMEOUT_START_TLS";
String NETTY_EXCEPTION_CNT = "NETTY_EXCEPTION_CNT";
+ String CLIENT_SEND_WAIT_TIMER = "CLIENT_SEND_WAIT_TIMER";
Review comment:
@sijie this is not actually add or read. This is time for either add or read
request when request send is blocked.
I am open for suggestions of better name, would CLIENT_NETTY_WAIT_TIMER or
CLIENT_WRITE_WAIT_TIMER sound better? though the wait is in ledger handle.
CLIENT_PCBC_WRITE_WAIT_TIMER might be better. though "write" can be confused
with add op.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
