dlg99 commented on a change in pull request #1088: ISSUE #1086 (@bug
W-4146427@) Client-side backpressure in netty (Fixes:
io.netty.util.internal.OutOfDirectMemoryError under continuous heavy load)
URL: https://github.com/apache/bookkeeper/pull/1088#discussion_r173341762
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ClientConfiguration.java
##########
@@ -416,7 +417,7 @@ public ClientConfiguration setClientReceiveBufferSize(int
bufferSize) {
* @return netty channel write buffer low water mark.
*/
public int getClientWriteBufferLowWaterMark() {
- return getInt(CLIENT_WRITEBUFFER_LOW_WATER_MARK, 32 * 1024);
+ return getInt(CLIENT_WRITEBUFFER_LOW_WATER_MARK, 384 * 1024);
Review comment:
goes along with answer on why HWM changed.
Pretty much set to 75% of HWM after couple of quick experiments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
