sijie commented on a change in pull request #1088: ISSUE #1086 (@bug
W-4146427@) Client-side backpressure in netty (Fixes:
io.netty.util.internal.OutOfDirectMemoryError under continuous heavy load)
URL: https://github.com/apache/bookkeeper/pull/1088#discussion_r170853969
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java
##########
@@ -501,6 +504,10 @@ PendingReadOp parallelRead(boolean enabled) {
return this;
}
+ void allowFastFailOnBlockedServer() {
Review comment:
"BlockedServer" is a confusing term here, since we don't really use
"blocker" at any other places. I would suggest changing it to
"allowFailFastOnUnwritableChannel".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
