sijie commented on a change in pull request #1088: ISSUE #1086 (@bug
W-4146427@) Client-side backpressure in netty (Fixes:
io.netty.util.internal.OutOfDirectMemoryError under continuous heavy load)
URL: https://github.com/apache/bookkeeper/pull/1088#discussion_r170853461
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ClientConfiguration.java
##########
@@ -797,6 +798,33 @@ public ClientConfiguration
setPCBCTimeoutTimerNumTicks(int numTicks) {
return this;
}
+ /**
+ * Timeout controlling wait on request send in case of unresponsive
bookie(s)
+ * (i.e. bookie in long GC etc.)
+ *
+ * @return timeout value
+ * negative value disables the feature
+ * 0 to allow request to fail immediately
+ * Default is 500
+ */
+ public long getWaitTimeoutOnBackpressureMillis() {
+ return getLong(WAIT_TIMEOUT_ON_BACKPRESSURE, 500);
Review comment:
I think we should make this default value as -1, util we have benchmarks
show 500 is in general good for most of applications.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
