sijie commented on a change in pull request #1088: ISSUE #1086 (@bug
W-4146427@) Client-side backpressure in netty (Fixes:
io.netty.util.internal.OutOfDirectMemoryError under continuous heavy load)
URL: https://github.com/apache/bookkeeper/pull/1088#discussion_r170853137
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieClient.java
##########
@@ -150,6 +150,12 @@ private int getRc(int rc) {
return faultyBookies;
}
+ public boolean isWritable(BookieSocketAddress address, long key) {
+ final PerChannelBookieClientPool pcbcPool = lookupClient(address);
+ // let write fail with whatever error it produces
Review comment:
is the comment aligned with the code here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
