sijie commented on a change in pull request #1088: ISSUE #1086 (@bug
W-4146427@) Client-side backpressure in netty (Fixes:
io.netty.util.internal.OutOfDirectMemoryError under continuous heavy load)
URL: https://github.com/apache/bookkeeper/pull/1088#discussion_r170853592
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ClientConfiguration.java
##########
@@ -437,7 +438,7 @@ public ClientConfiguration
setClientWriteBufferLowWaterMark(int waterMark) {
* @return netty channel write buffer high water mark.
*/
public int getClientWriteBufferHighWaterMark() {
- return getInt(CLIENT_WRITEBUFFER_HIGH_WATER_MARK, 64 * 1024);
+ return getInt(CLIENT_WRITEBUFFER_HIGH_WATER_MARK, 512 * 1024);
Review comment:
why 512?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
