ivankelly commented on a change in pull request #832: Issue 620: Close the
fileChannels for read when they are idle
URL: https://github.com/apache/bookkeeper/pull/832#discussion_r170900661
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
##########
@@ -993,56 +1006,58 @@ synchronized boolean readEntryLogHardLimit(long size) {
public ByteBuf internalReadEntry(long ledgerId, long entryId, long
location)
throws IOException, Bookie.NoEntryException {
- long entryLogId = logIdForOffset(location);
- long pos = location & 0xffffffffL;
- ByteBuf sizeBuff = sizeBuffer.get();
- sizeBuff.clear();
- pos -= 4; // we want to get the ledgerId and length to check
- BufferedReadChannel fc;
+ EntryLogBufferedReadChannel bc = null;
try {
- fc = getChannelForLogId(entryLogId);
+ long entryLogId = logIdForOffset(location);
Review comment:
What is this change for? It looks pretty much the same as it was before,
with the exception handling changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
