ivankelly commented on a change in pull request #832: Issue 620: Close the
fileChannels for read when they are idle
URL: https://github.com/apache/bookkeeper/pull/832#discussion_r171541740
##########
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/EntryLogTest.java
##########
@@ -346,16 +344,15 @@ public void testCacheInEntryLog() throws Exception {
//since last access, expire after 1s
conf.setReadChannelCacheExpireTimeMs(expireTime);
conf.setEntryLogFilePreAllocationEnabled(false);
- // below one will cost logId 0
- Bookie bookie = new Bookie(conf);
+ LedgerDirsManager ledgerDirsManager = new LedgerDirsManager(conf,
conf.getLedgerDirs(),
+ new DiskChecker(conf.getDiskUsageThreshold(),
conf.getDiskUsageWarnThreshold()));
Review comment:
Is there not a DummyDiskChecker that does nothing? If not, set both
thresholds to 1. We're not testing the checker stuff, and it would cause a
failure if your disk is over 95% full.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
