ivankelly commented on a change in pull request #832: Issue 620: Close the
fileChannels for read when they are idle
URL: https://github.com/apache/bookkeeper/pull/832#discussion_r171520257
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
##########
@@ -703,7 +716,7 @@ void stop() {
* Entry Log File Id
*/
protected boolean removeEntryLog(long entryLogId) {
- removeFromChannelsAndClose(entryLogId);
+ fileChannelBackingCache.removeFromChannelsAndClose(entryLogId);
Review comment:
I guess it would throw an exception when the file is eventually dropped from
all caches and it tries to close it. This could be unpredictable, as removals
happen when another action trigger it, like a put, and it's that put that would
get the exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
