ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r171521936
########## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java ########## @@ -1174,24 +1208,19 @@ private File findFile(long logId) throws FileNotFoundException { * @throws IOException */ public void scanEntryLog(long entryLogId, EntryLogScanner scanner) throws IOException { - // Buffer where to read the entrySize (4 bytes) and the ledgerId (8 bytes) - ByteBuf headerBuffer = Unpooled.buffer(4 + 8); - BufferedReadChannel bc; - // Get the BufferedChannel for the current entry log file + EntryLogBufferedReadChannel bc = null; Review comment: I'm questioning it, because it creates noise the in patch. Theres a bunch of lines added and deleted, which are likely exactly the same, but they need to be checked anyhow. If you need to refactor, it's better to do in a separate patch which doesn't change any logic. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services