dlg99 commented on a change in pull request #1088: ISSUE #1086 (@bug
W-4146427@) Client-side backpressure in netty (Fixes:
io.netty.util.internal.OutOfDirectMemoryError under continuous heavy load)
URL: https://github.com/apache/bookkeeper/pull/1088#discussion_r173343917
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
##########
@@ -450,6 +451,18 @@ void cleanDisconnectAndClose() {
close();
}
+ /**
+ *
+ * @return boolean, true is PCBC is writable
+ */
+ public boolean isWritable() {
Review comment:
there is no isWritable method in ChannelInboundHandlerAdapter which PCBC
extends.
Annotation is not needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
