reddycharan commented on a change in pull request #1236: Issue #570: make
changes to SyncThread/checkpoint logic.
URL: https://github.com/apache/bookkeeper/pull/1236#discussion_r174039621
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/InterleavedLedgerStorage.java
##########
@@ -331,9 +333,16 @@ private void flushOrCheckpoint(boolean isCheckpointFlush)
}
try {
- // if it is just a checkpoint flush, we just flush rotated entry
log files
- // in entry logger.
- if (isCheckpointFlush) {
+ /*
+ * if it is just a checkpoint flush and if entryLogPerLedger is not
+ * enabled, then we just flush rotated entry log files in entry
+ * logger.
+ *
+ * In the case of entryLogPerLedgerEnabled we need to flush both
+ * rotatedlogs and currentlogs. Hence we call entryLogger.flush in
+ * the case of entrylogperledgerenabled.
+ */
+ if (isCheckpointFlush && !entryLogPerLedgerEnabled) {
Review comment:
for now moved this if-else block to EntryLogger.checkpoint. In the
subsequent tasks when I introduce EntrylogManager, I'll move the implementation
of checkpoint to individual implementations of EntryLogManager.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
