reddycharan commented on a change in pull request #1236: Issue #570: make changes to SyncThread/checkpoint logic. URL: https://github.com/apache/bookkeeper/pull/1236#discussion_r174231934
########## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/SortedLedgerStorageCheckpointTest.java ########## @@ -110,15 +110,27 @@ public void setUp() throws Exception { // initial checkpoint this.storage = new SortedLedgerStorage(); - this.checkpointer = checkpoint -> storage.getScheduler().submit(() -> { - log.info("Checkpoint the storage at {}", checkpoint); - try { - storage.checkpoint(checkpoint); - checkpoints.add(checkpoint); - } catch (IOException e) { - log.error("Failed to checkpoint at {}", checkpoint, e); + this.checkpointer = new Checkpointer() { + @Override + public void startCheckpoint(Checkpoint checkpoint) { + // TODO Auto-generated method stub Review comment: removed it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services