[
https://issues.apache.org/jira/browse/CALCITE-1254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297623#comment-15297623
]
Julian Hyde commented on CALCITE-1254:
--------------------------------------
And some more issues:
1. There still calls within Avatica to the deprecated form of
{{prepareAndExecute}}. Wouldn’t it be wise to upgrade all internal uses?
2. Why does {{prepareAndExecuteBatch}} not have a {{PrepareCallback}} parameter
like {{prepareAndExecute}}? It makes it difficult to implement it in the
obvious way.
3. Clarify what {{closeStatement(StatementHandle)}} should do if the statement
handle is invalid. Throw or do nothing? I think it's OK to no-op, but the
documentation should specify (the implementation will need to ignore a
NoSuchStatementException).
4. I tried to upgrade Calcite to Avatica 1.8.0 and it’s not trivial, due to the
issues above. I have pushed my work to the branch
https://github.com/julianhyde/calcite/tree/1280-upgrade-avatica (yeah, I got
the branch name wrong considering I'm fixing CALCITE-1239). I’d like to make
sure that implementing the new APIs is possible before we approve the Avatica
1.8.0 release. Selfishly, it helps Calcite, but I think it also helps Avatica.
> Support PreparedStatement.executeLargeBatch
> -------------------------------------------
>
> Key: CALCITE-1254
> URL: https://issues.apache.org/jira/browse/CALCITE-1254
> Project: Calcite
> Issue Type: Bug
> Reporter: Julian Hyde
> Assignee: Julian Hyde
>
> In CALCITE-1128 we added support for PreparedStatement.executeBatch. This
> added ExecuteBatchResult with a field {{int[] updateCounts}}.
> I think that field should have been {{long[]}} instead. Elsewhere we have
> been converting update counts from {{int}} to {{long}}, in line with changes
> to the JDBC API.
> If changing this field from {{int[]}} to {{long[]}} will be a breaking change
> we should consider halting 1.8 to get this in.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
