[
https://issues.apache.org/jira/browse/CALCITE-1254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15305490#comment-15305490
]
Josh Elser commented on CALCITE-1254:
-------------------------------------
bq. Why does prepareAndExecuteBatch not have a PrepareCallback parameter like
prepareAndExecute? It makes it difficult to implement it in the obvious way.
Aren't the semantics of these methods different though? {{Statement#execute()}}
is returning a boolean whereas {{Statement.executeBatch()}} (and the
corresponding methods on PreparedStatement) are returning the value directly.
Maybe I'm missing some intricacy (some other method on Statement?), but I'm not
seeing why we actually need to update any state on the Statement (as its passed
directly to the caller)
> Support PreparedStatement.executeLargeBatch
> -------------------------------------------
>
> Key: CALCITE-1254
> URL: https://issues.apache.org/jira/browse/CALCITE-1254
> Project: Calcite
> Issue Type: Bug
> Components: avatica
> Reporter: Julian Hyde
> Assignee: Josh Elser
> Fix For: avatica-1.8.0
>
>
> In CALCITE-1128 we added support for PreparedStatement.executeBatch. This
> added ExecuteBatchResult with a field {{int[] updateCounts}}.
> I think that field should have been {{long[]}} instead. Elsewhere we have
> been converting update counts from {{int}} to {{long}}, in line with changes
> to the JDBC API.
> If changing this field from {{int[]}} to {{long[]}} will be a breaking change
> we should consider halting 1.8 to get this in.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
