[
https://issues.apache.org/jira/browse/CALCITE-1254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15308458#comment-15308458
]
Josh Elser commented on CALCITE-1254:
-------------------------------------
[~julianhyde], one change you made I didn't roll into my final commit (checking
with you before I push it to origin). With HEAD of [my
branch|https://github.com/joshelser/calcite/tree/1254-executeLargeBatch], I was
able to build your 1280 branch.
In
[AvaticaConnection|https://github.com/julianhyde/calcite/commit/0615499156de06c43fb06890f7cceba29b92ab3e#diff-1a64d11e275e3b91d02bfd68b217a991R610]
and
[RemoteMeta|https://github.com/julianhyde/calcite/commit/0615499156de06c43fb06890f7cceba29b92ab3e#diff-1ae3d3d471f00cc7c597728b9b69edb3R248],
you had set the new {{maxRowsInFirstFrame}} argument to {{prepareAndExecute}}
to {{-1}} instead of reusing {{maxRowCount}}. I think this is a little jarring
as it might change the semantics of the (now deprecated) {{prepareAndExecute}}
variant (potentially breaking someone downstream). Does this make sense to you
to revert those {{-1}}'s back to {{(int) maxRowCount}}? This change is what I
have staged in my branch now.
> Support PreparedStatement.executeLargeBatch
> -------------------------------------------
>
> Key: CALCITE-1254
> URL: https://issues.apache.org/jira/browse/CALCITE-1254
> Project: Calcite
> Issue Type: Bug
> Components: avatica
> Reporter: Julian Hyde
> Assignee: Josh Elser
> Priority: Blocker
> Fix For: avatica-1.8.0
>
>
> In CALCITE-1128 we added support for PreparedStatement.executeBatch. This
> added ExecuteBatchResult with a field {{int[] updateCounts}}.
> I think that field should have been {{long[]}} instead. Elsewhere we have
> been converting update counts from {{int}} to {{long}}, in line with changes
> to the JDBC API.
> If changing this field from {{int[]}} to {{long[]}} will be a breaking change
> we should consider halting 1.8 to get this in.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
