[ 
https://issues.apache.org/jira/browse/CALCITE-1254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15306370#comment-15306370
 ] 

Julian Hyde commented on CALCITE-1254:
--------------------------------------

I started with https://github.com/joshelser/calcite/tree/1254-executeLargeBatch 
and fixed all remaining issues listed in this case, committed as 
https://github.com/julianhyde/calcite/tree/1254-executeLargeBatch. [~elserj], 
Can you review, squash into your work and commit? (No need to retain my commit 
as a separate commit.)

(My latest https://github.com/julianhyde/calcite/tree/1280-upgrade-avatica 
works against the new Avatica API.)

> Support PreparedStatement.executeLargeBatch
> -------------------------------------------
>
>                 Key: CALCITE-1254
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1254
>             Project: Calcite
>          Issue Type: Bug
>          Components: avatica
>            Reporter: Julian Hyde
>            Assignee: Josh Elser
>            Priority: Blocker
>             Fix For: avatica-1.8.0
>
>
> In CALCITE-1128 we added support for PreparedStatement.executeBatch. This 
> added ExecuteBatchResult with a field {{int[] updateCounts}}.
> I think that field should have been {{long[]}} instead. Elsewhere we have 
> been converting update counts from {{int}} to {{long}}, in line with changes 
> to the JDBC API.
> If changing this field from {{int[]}} to {{long[]}} will be a breaking change 
> we should consider halting 1.8 to get this in.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to