[
https://issues.apache.org/jira/browse/CALCITE-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990067#comment-15990067
]
Julian Hyde commented on CALCITE-1769:
--------------------------------------
Sorry, it's your responsibility to produce code that is well formatted and easy
to read and maintain. IDEs don't format code perfectly; you can't blame the
tool, or put the burden on me to configure your IDE's formatter.
I need some rationale why it is safe to push numeric casts down. Is it safe to
push down casts of other types? What happens if you cast a string to a numeric
but it is not a valid number?
I have the impression that you're solving one particular bug. But if you don't
think around the problem, you may be creating other bugs, and you may be
leaving other bugs un-fixed.
Frankly I see a lot of small fixes going into the Druid adapter and that makes
me think that people are not thinking enough about the big picture. That is a
quality problem.
> Push Filters down to druid when there a cast to numeric
> -------------------------------------------------------
>
> Key: CALCITE-1769
> URL: https://issues.apache.org/jira/browse/CALCITE-1769
> Project: Calcite
> Issue Type: Bug
> Components: druid
> Reporter: slim bouguerra
> Assignee: Julian Hyde
> Fix For: 1.13.0
>
>
> Currently if we have cast to numeric over literal filter will not get pushed.
> For instance query like {code}SELECT page from druid_table_1 WHERE page < 5
> group by page {code} from hive will introduce a cast over `5`.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
