[
https://issues.apache.org/jira/browse/CALCITE-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991637#comment-15991637
]
slim bouguerra commented on CALCITE-1769:
-----------------------------------------
Rather than putting a blank statement that sounds targeting my recent
contributions to druid adapter, i think it is better to highlight the 4 issues,
like that all devs can learn from it and it does not target a specific person.
Making a blank statement about code quality and targeting a person i don't
think it is a great form of constructive feedback, in fact it does hurt peoples
feelings.
Again i am here to learn and to contribute, all the patches i have sent
recently contains IT testing which improves the overall code quality i believe.
Updated the pr with the suggested code style.
> Push Filters down to druid when there a cast to numeric
> -------------------------------------------------------
>
> Key: CALCITE-1769
> URL: https://issues.apache.org/jira/browse/CALCITE-1769
> Project: Calcite
> Issue Type: Bug
> Components: druid
> Reporter: slim bouguerra
> Assignee: Julian Hyde
> Fix For: 1.13.0
>
>
> Currently if we have cast to numeric over literal filter will not get pushed.
> For instance query like {code}SELECT page from druid_table_1 WHERE page < 5
> group by page {code} from hive will introduce a cast over `5`.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
