[
https://issues.apache.org/jira/browse/CALCITE-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990096#comment-15990096
]
slim bouguerra commented on CALCITE-1769:
-----------------------------------------
Please keep in mind that often there are several valid ways to line-wrap the
same piece of code.
Therefore there is no deterministic guiding showing exactly how to break the
line.
This means we are getting into discussions about personal tastes and
preferences that never ends and takes the synergy out of the project.
Again if you can layout you personal preference in a document, i am willing to
follow it, i don't think i can do more than that.
Multiple projects use formatting templates to do most of the deterministic
formatting and it works pretty well.
For instance we can try the Druid one or Google's one.
Looking at the [ CALCITE jiras|
https://issues.apache.org/jira/browse/CALCITE-1769?filter=-2&jql=project%20%3D%20CALCITE%20AND%20reporter%20in%20(bslim)%20ORDER%20BY%20createdDate%20DESC]
you can see that mostly are bug fixes for existing code or adding new
features like extraction functions.
Frankly, saying that we have a quality problem is little bit rude and i don't
think that is a good way to welcome contributions.
> Push Filters down to druid when there a cast to numeric
> -------------------------------------------------------
>
> Key: CALCITE-1769
> URL: https://issues.apache.org/jira/browse/CALCITE-1769
> Project: Calcite
> Issue Type: Bug
> Components: druid
> Reporter: slim bouguerra
> Assignee: Julian Hyde
> Fix For: 1.13.0
>
>
> Currently if we have cast to numeric over literal filter will not get pushed.
> For instance query like {code}SELECT page from druid_table_1 WHERE page < 5
> group by page {code} from hive will introduce a cast over `5`.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
