[
https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16575269#comment-16575269
]
Vladimir Sitnikov commented on CALCITE-2457:
--------------------------------------------
{quote}This discussion is missing one important consideration: how much effort
is required to update reference data
{quote}
That is a very valid point.
In other words, there should be a more-or-less trivial way to update test code
so expected values are set to the current actuals.
In other words, a mere use of Kotlin's multiline strings in assertions would
not qualify since one would have to manually replace the string for "expected
value" in the test code.
That is one of the test artifacts should be the updated test code.
{quote} It is not practical to write a test that checks that a 100-line plan
contains lines X, Y and Z.{quote}
I'm sure assertions like "expression 5 at line 97 should be x>5" is not the
thing we want to have in tests.
{quote}Quidem's language (its set of commands) allow assertions on the output
{quote}
I find Quidem's language obscure:
1) IDE does not highlight syntax
2) IDE does not provide auto-complete
3) It is hard to debug
4) Quidem is string=>string kind of test, and it is not suitable for testing
linq4j or something like that
> Upgrade to JUnit 5
> ------------------
>
> Key: CALCITE-2457
> URL: https://issues.apache.org/jira/browse/CALCITE-2457
> Project: Calcite
> Issue Type: Improvement
> Reporter: Vladimir Sitnikov
> Assignee: Julian Hyde
> Priority: Major
> Attachments: assert_equals.png, truth_assertmap.png
>
>
> JUnit 5 brings multiple useful features so tests are easier to read and write.
> Is there something that blocks upgrading to JUnit 5?
> By upgrade I mean bumping up the dependency version and creating new tests
> with JUnit 5 features.
> Relevant features of JUnit 5: dynamic test, nested tests, parameterized tests
> https://twitter.com/nipafx/status/1027095088059559936
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
