[ 
https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16575028#comment-16575028
 ] 

Andrei Sereda commented on CALCITE-2457:
----------------------------------------

It should be relatively easy to create Subject for calcite Queries / logical 
plans:

h3. Example
{code:java}
assertThat(Sql.create("select * from ...")).hasLogicalPlan("....", "...");
{code}

In this case subject has all necessary information (sql, expected and logical 
plans). Comparison can be done based on string representation so exception is 
correctly interpreted by the IDE (for diff link).

 

> Upgrade to JUnit 5
> ------------------
>
>                 Key: CALCITE-2457
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2457
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Vladimir Sitnikov
>            Assignee: Julian Hyde
>            Priority: Major
>         Attachments: assert_equals.png, truth_assertmap.png
>
>
> JUnit 5 brings multiple useful features so tests are easier to read and write.
> Is there something that blocks upgrading to JUnit 5?
> By upgrade I mean bumping up the dependency version and creating new tests 
> with JUnit 5 features.
> Relevant features of JUnit 5: dynamic test, nested tests, parameterized tests
> https://twitter.com/nipafx/status/1027095088059559936



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to