[
https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16574409#comment-16574409
]
Vladimir Sitnikov commented on CALCITE-2457:
--------------------------------------------
{quote}For failure you don't like error message ? Or is it what you expected ?
{quote}
Here's what would like to see: !assert_equals.png!
There's a query plan. Currently it is serialized to string and passed to
{{assertEquals}}
That has pros and cons:
1) Pro: diff in IDE works great.
2) Cons: CI logs would miss "diff view", so CI logs would have just "expected:
..... got: .... " kind of puzzle. "assert message" in this case is just "sql",
so failure in the CI would be hard to reason about, but we have discussed that
already.
Would special "plan comparator" improve the experience? I'm not that sure. It
would require great amount of work in order to create great diff implementation
for logical plans. Does Truth/AssertJ have most of the bits implemented? I
doubt so.
Arrays, Iterables, Maps is something to build up on, however Calcite needs more
involved objects, and it looks like no one wanted to invest much time in
creating extremely sophisticated comparators.
> Upgrade to JUnit 5
> ------------------
>
> Key: CALCITE-2457
> URL: https://issues.apache.org/jira/browse/CALCITE-2457
> Project: Calcite
> Issue Type: Improvement
> Reporter: Vladimir Sitnikov
> Assignee: Julian Hyde
> Priority: Major
> Attachments: assert_equals.png, truth_assertmap.png
>
>
> JUnit 5 brings multiple useful features so tests are easier to read and write.
> Is there something that blocks upgrading to JUnit 5?
> By upgrade I mean bumping up the dependency version and creating new tests
> with JUnit 5 features.
> Relevant features of JUnit 5: dynamic test, nested tests, parameterized tests
> https://twitter.com/nipafx/status/1027095088059559936
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
