[
https://issues.apache.org/jira/browse/CALCITE-3008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822176#comment-16822176
]
Rong Rong commented on CALCITE-3008:
------------------------------------
In the public interface change way, we have to explicitly cast the call to a
SqlGroupedWindowFunction, which I think in [~julianhyde]'s original design, is
only one of the possible GroupFunction that requires an auxiliary conversion.
However, in the factory design. depending on the type of group-to-auxiliary
relationship, we can change the conversion mechanism. (thus no need to
hard-coded a cast to SqlGroupedWindowFunction object.
I am open to both, since there're both ways to extend to future use cases IMO,
just the mechanism might've been different.
> Making AuxiliaryConverter Pluggable
> -----------------------------------
>
> Key: CALCITE-3008
> URL: https://issues.apache.org/jira/browse/CALCITE-3008
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: Rong Rong
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently the {{AuxiliaryConverter}} in calcite core is set to be static with
> only one basic implementation. It would be nice to have it pluggable so that
> other systems can implement its own.
> Was wondering if this would be a good feature to add?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
