[ 
https://issues.apache.org/jira/browse/CALCITE-3008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826613#comment-16826613
 ] 

Rong Rong commented on CALCITE-3008:
------------------------------------

Hi [~julianhyde]. I dug a bit deeper into the AuxiliaryConverter usage. seems 
like currently it is used very specifically to convert group expressions into 
auxiliary group function. Thus it requires 2 RexNodes (groupCall and resultExp).

In order to support the ability to convert user-defined function. I am not sure 
if this also is limited to the scope of only converting Group expressions? what 
would a good example of this be? (for example, GROUP BY TUMBLE_ROWTIME() ?)

Another question is regarding the approach: 
 when you mention to add {{SqlFunction getAuxiliaryConverter(SqlFunction)}} to 
{{SqlOperatorTable}}. I am assuming some sort of approaches similar to 
{{RexSqlConvertletTable}} ? where user can change the convertlet table, 
correct? 
 Also just to double check, I think you meant: {{*AuxiliaryConverter* 
getAuxiliaryConverter(SqlFunction)}}, correct?

> Making AuxiliaryConverter Pluggable
> -----------------------------------
>
>                 Key: CALCITE-3008
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3008
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Rong Rong
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Currently the {{AuxiliaryConverter}} in calcite core is set to be static with 
> only one basic implementation. It would be nice to have it pluggable so that 
> other systems can implement its own. 
> Was wondering if this would be a good feature to add? 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to