[ 
https://issues.apache.org/jira/browse/CALCITE-3008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16823389#comment-16823389
 ] 

Julian Hyde commented on CALCITE-3008:
--------------------------------------

AuxiliaryConverter goes Rex -> Rex, whereas RexSqlConvertlet goes Rex -> 
SqlNode. I don't think we should combine these interfaces because they are 
going between different layers.

(Rex and SqlNode code are somewhat intertwined but they would be much much 
worse if we didn't make a conscious effort to reduce coupling. Sql2Rel and 
Rel2Sql necessarily touch both.)

> Making AuxiliaryConverter Pluggable
> -----------------------------------
>
>                 Key: CALCITE-3008
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3008
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Rong Rong
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Currently the {{AuxiliaryConverter}} in calcite core is set to be static with 
> only one basic implementation. It would be nice to have it pluggable so that 
> other systems can implement its own. 
> Was wondering if this would be a good feature to add? 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to