[
https://issues.apache.org/jira/browse/CALCITE-3008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16823316#comment-16823316
]
Rong Rong commented on CALCITE-3008:
------------------------------------
I also think changing the AuxiliaryConverter seems to limit the capability of
the converter - Unlike {{RexSqlConvertlet}} which can also include the
{{RexContext}} as part of the conversion call.
I have a question actually: are we suggesting to create a {{RelSqlConvertlet}}
interface that is generic enough to convert any operator, and create an
implementation of the current {{AuxiliaryConverter}} in the
{{StandardConvertletTable}}?
I think this would be a good idea since we already use the
{{exprConverter.convertCall}} in some of the code path in the {{
SqlToRelConverter}} like OVER conversion. It doesn't need too much change to
push this to the AGG conversion path.
What do you think [~hyuan] [~julianhyde]
> Making AuxiliaryConverter Pluggable
> -----------------------------------
>
> Key: CALCITE-3008
> URL: https://issues.apache.org/jira/browse/CALCITE-3008
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: Rong Rong
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently the {{AuxiliaryConverter}} in calcite core is set to be static with
> only one basic implementation. It would be nice to have it pluggable so that
> other systems can implement its own.
> Was wondering if this would be a good feature to add?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
