[
https://issues.apache.org/jira/browse/CALCITE-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897574#comment-16897574
]
Julian Hyde commented on CALCITE-3187:
--------------------------------------
Yeah, I don't know why the compiler complains about implementing deprecated
methods. But it does, so we have to stop it complaining.
I wouldn't have added documentation to methods I'd just marked deprecated. (And
in general, I avoid documenting methods that implement or override a method in
a base class or interface.)
Your change looks good. Just make sure that {{-Werror}} doesn't cause problems
on any JDK version 8 .. 13.
> Derive all decimal return type through type factory
> ---------------------------------------------------
>
> Key: CALCITE-3187
> URL: https://issues.apache.org/jira/browse/CALCITE-3187
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: Praveen Kumar Desabandu
> Assignee: Laurent Goujon
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.21.0
>
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> Currently decimal product and quotient return types are derived through type
> factory, this allows clients to override the return type if they so desire.
> But decimal sum is embedded in return types, also decimal mod does not have a
> return type inference defined.
> This task is to derive all of the return types through type factory, so that
> clients can override if they wish to.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
