[
https://issues.apache.org/jira/browse/CALCITE-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897467#comment-16897467
]
Julian Hyde commented on CALCITE-3187:
--------------------------------------
Build now gives deprecation warnings:
{noformat}
core/src/main/java/org/apache/calcite/rel/type/RelDataTypeFactoryImpl.java:[485,22]
createDecimalQuotient(org.apache.calcite.rel.type.RelDataType,org.apache.calcite.rel.type.RelDataType)
in org.apache.calcite.rel.type.RelDataTypeFactory has been deprecated
core/src/main/java/org/apache/calcite/rel/type/RelDataTypeFactoryImpl.java:[474,18]
useDoubleMultiplication(org.apache.calcite.rel.type.RelDataType,org.apache.calcite.rel.type.RelDataType)
in org.apache.calcite.rel.type.RelDataTypeFactory has been deprecated
core/src/main/java/org/apache/calcite/rel/type/RelDataTypeFactoryImpl.java:[463,22]
createDecimalProduct(org.apache.calcite.rel.type.RelDataType,org.apache.calcite.rel.type.RelDataType)
in org.apache.calcite.rel.type.RelDataTypeFactory has been deprecated
core/src/main/java/org/apache/calcite/rel/rules/SubQueryRemoveRule.java:[201,45]
makeNullLiteral(org.apache.calcite.sql.type.SqlTypeName) in
org.apache.calcite.rex.RexBuilder has been deprecated
core/src/main/java/org/apache/calcite/rel/rules/SubQueryRemoveRule.java:[244,45]
makeNullLiteral(org.apache.calcite.sql.type.SqlTypeName) in
org.apache.calcite.rex.RexBuilder has been deprecated
core/src/main/java/org/apache/calcite/rel/rules/ReduceDecimalsRule.java:[942,35]
useDoubleMultiplication(org.apache.calcite.rel.type.RelDataType,org.apache.calcite.rel.type.RelDataType)
in org.apache.calcite.rel.type.RelDataTypeFactory has been deprecated{noformat}
We have zero tolerance on such warnings. Please fix ASAP. Consider using
{{default}} methods in {{RelDataTypeFactory}} and remove the methods from
{{RelDataTypeFactoryImpl}}.
Also, [~laurent], as reviewer, please make sure that the commit message adheres
to the standard: {{[CALCITE-xxxx]}} not {{CALCITE-xxxx:}}.
> Derive all decimal return type through type factory
> ---------------------------------------------------
>
> Key: CALCITE-3187
> URL: https://issues.apache.org/jira/browse/CALCITE-3187
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: Praveen Kumar Desabandu
> Assignee: Laurent Goujon
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.21.0
>
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> Currently decimal product and quotient return types are derived through type
> factory, this allows clients to override the return type if they so desire.
> But decimal sum is embedded in return types, also decimal mod does not have a
> return type inference defined.
> This task is to derive all of the return types through type factory, so that
> clients can override if they wish to.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
