[ 
https://issues.apache.org/jira/browse/CALCITE-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897552#comment-16897552
 ] 

Laurent Goujon commented on CALCITE-3187:
-----------------------------------------

For {{RelDataTypeFactoryImpl}}, shouldn't I suppress the warning instead by 
adding {{@Deprecated}} to these methods? They were already existing before the 
patch, it just happened I added {{@Deprecated}} to the interface, but their 
body do not use deprecated code.

It would be nice also if the compiler could be configured to error for 
warnings, instead of just printing out if we have no tolerance for those.

> Derive all decimal return type through type factory
> ---------------------------------------------------
>
>                 Key: CALCITE-3187
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3187
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Praveen Kumar Desabandu
>            Assignee: Laurent Goujon
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.21.0
>
>          Time Spent: 4.5h
>  Remaining Estimate: 0h
>
> Currently decimal product and quotient return types are derived through type 
> factory, this allows clients to override the return type if they so desire.
> But decimal sum is embedded in return types, also decimal mod does not have a 
> return type inference defined.
> This task is to derive all of the return types through type factory, so that 
> clients can override if they wish to.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to