[
https://issues.apache.org/jira/browse/CALCITE-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16882235#comment-16882235
]
Laurent Goujon commented on CALCITE-3187:
-----------------------------------------
I was wondering about this. It seems that long time (6year) ago, methods
{{createDecimalProduct}}/{{createDecimalQuotient}} were added to
{{RelDataTypeFactory}}. But later on (2year ago), several methods were added to
{{RelDataTypeFactory}} to derive return type for agg functions (like
{{deriveSum}}).
Should we add the new {{createDecimal}} methods to {{RelDataTypeFactory}} for
consistency, and to {{RelDataTypeFactory}} which seems to be the new place for
deriving return types. Maybe the original methods can be moved too (with
deprecation and redirecting to the type system?)
> Derive all decimal return type through type factory
> ---------------------------------------------------
>
> Key: CALCITE-3187
> URL: https://issues.apache.org/jira/browse/CALCITE-3187
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: Praveen Kumar Desabandu
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Currently decimal product and quotient return types are derived through type
> factory, this allows clients to override the return type if they so desire.
> But decimal sum is embedded in return types, also decimal mod does not have a
> return type inference defined.
> This task is to derive all of the return types through type factory, so that
> clients can override if they wish to.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
