[
https://issues.apache.org/jira/browse/CALCITE-4644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367484#comment-17367484
]
Julian Hyde commented on CALCITE-4644:
--------------------------------------
I saw that you reference SqlKind.PERCENTILE_CONT and PERCENTILE_DISC explicitly
in the validator. We generally validate based on properties, e.g.
{{SqlAggFunction.requiresOrder}}. Maybe we need new properties?
Adding a property has been tricky in the past (because it required new
constructor parameters or methods) but is easier now we have class
{{SqlBasicAggFunction}}. Could you base your new aggregate functions on
{{SqlBasicAggFunction}}? Recently added aggregate functions {{COLLECT}},
{{FUSION}}, {{INTERSECTION}} have done this.
The word 'positive' means 'greater than zero'. So you should not use it in your
class name or error message. What error message does, say, PostgreSQL give if
the argument is less than zero or greater than one?
> Add PERCENTILE_CONT and PERCENTILE_DISC aggregate functions
> -----------------------------------------------------------
>
> Key: CALCITE-4644
> URL: https://issues.apache.org/jira/browse/CALCITE-4644
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: Rafay A
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Add percentile functions in the operator table.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
