[ 
https://issues.apache.org/jira/browse/CALCITE-4644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370677#comment-17370677
 ] 

Julian Hyde commented on CALCITE-4644:
--------------------------------------

I’d remove TODOs. They don’t help maintainers. A jira case is better. Start a 
new branch containing the TODOs and beginnings of a fix for the next issue.

Add the method to SqlAggFunction, returning false by default, not 
SqlBasicAggFunction. The instanceof and downcast is ugly. 

> Add PERCENTILE_CONT and PERCENTILE_DISC aggregate functions
> -----------------------------------------------------------
>
>                 Key: CALCITE-4644
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4644
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Rafay A
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> Add percentile functions in the operator table.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to