[
https://issues.apache.org/jira/browse/CALCITE-4644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17371031#comment-17371031
]
Julian Hyde commented on CALCITE-4644:
--------------------------------------
Ah, now I understand that you had removed the method
{{SqlBasicAggFunction.isPercentile()}} and added a visitor. Well, I don't think
the visitor is the right direction. We want aggregate functions to be
declarative - that is, provide the information for the validator to validate
them.
Also, tests that generate error messages should be in SqlValidatorTest, not
SqlToRelConverterTest.
I'm going to fork your PR and add a few commits that indicate what I'm
thinking. I'll post in an hour or so.
> Add PERCENTILE_CONT and PERCENTILE_DISC aggregate functions
> -----------------------------------------------------------
>
> Key: CALCITE-4644
> URL: https://issues.apache.org/jira/browse/CALCITE-4644
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: Rafay A
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4h
> Remaining Estimate: 0h
>
> Add percentile functions in the operator table.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
