Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2347#discussion_r191386255
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/datatypes/PrimitiveDataType.java
---
@@ -288,7 +288,12 @@ public int getSurrogateIndex() {
logHolder.setReason(message);
}
} else {
- surrogateKey = dictionaryGenerator.getOrGenerateKey(parsedValue);
+ if (dictionaryGenerator instanceof DirectDictionary
--- End diff --
@Override public void writeByteArray(Object input, DataOutputStream
dataOutputStream,
BadRecordLogHolder logHolder) throws IOException,
DictionaryGenerationException {
String parsedValue =
input == null ? null : DataTypeUtil.parseValue(input.toString(),
carbonDimension);
If the input is long, is it needed to parse as toString?
---
